Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SEPA Payment Account country: GI (Gibraltar) #6722

Merged
merged 2 commits into from Jun 20, 2023
Merged

Add SEPA Payment Account country: GI (Gibraltar) #6722

merged 2 commits into from Jun 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2023

Fixes #6721

Existing accounts can be edited to accept offers from GI:

image

Screenshot showing a Gibraltar IBAN used in a trade:

image

helixx87
helixx87 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@helixx87 helixx87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alvasw
alvasw approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

After editing the "Accept trade from these [...] countries", it's still not possible to take already published offers. This bug existed already before this change.

alejandrogarcia83
alejandrogarcia83 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 5439108 into bisq-network:master Jun 20, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.11 milestone Jun 20, 2023
@alvasw alvasw mentioned this pull request Jul 17, 2023
Closed
@ghost ghost mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.11
Development

Successfully merging this pull request may close these issues.

SEPA payments should allow "Gibraltar" as bank country
3 participants
@alvasw @alejandrogarcia83 @helixx87